fix curseforge provider, general provider refactoring

src/parser.ts

@@ -17,19 +17,19 @@ export abstract class Provider {
     public hashFormat: string,
   ) {}
 
-  abstract getDownloadUrl(): Promise<Resource>;
+  abstract get downloadUrl(): Resource;
 }
 
 export class UrlProvider extends Provider {
   constructor(
     public hash: string,
     public hashFormat: string,
-    public url: string,
+    private url: string,
   ) {
     super(hash, hashFormat);
   }
 
-  async getDownloadUrl(): Promise<Resource> {
+  get downloadUrl(): Resource {
     return new Resource(this.url);
   }
 }
@@ -71,11 +71,10 @@ export class CurseForgeProvider extends Provider {
     super(hash, hashFormat);
   }
 
-  async getDownloadUrl(): Promise<Resource> {
-    // const mod = await CURSE_CLIENT.getMod(this.projectId);
-    // const file = await mod.getFile(this.fileId);
-    // return new Resource(await file.getDownloadURL());
-    return new Resource("https://google.com/search?q=curseforge+sucks"); // TODO: figure this out, i hate curseforge
+  get downloadUrl(): Resource {
+    return new Resource(
+      `https://www.curseforge.com/api/v1/mods/${this.projectId}/files/${this.fileId}/download`,
+    );
   }
 }
 

src/resource.ts

@@ -5,11 +5,11 @@ import * as path from "path";
 export default class Resource {
   constructor(public readonly path: string) {}
 
-  toString() {
+  toString(): string {
     return this.path;
   }
 
-  get isUrl() {
+  get isUrl(): boolean {
     try {
       new URL(this.path);
       return true;
@@ -18,13 +18,13 @@ export default class Resource {
     }
   }
 
-  get name() {
+  get name(): string {
     return this.isUrl
       ? new URL(this.path).pathname.split("/").pop() || ""
       : path.basename(this.path);
   }
 
-  get parent() {
+  get parent(): Resource {
     if (this.isUrl) {
       const url = new URL(this.path);
       url.pathname = path.dirname(url.pathname);
@@ -33,7 +33,7 @@ export default class Resource {
     return new Resource(path.dirname(this.path));
   }
 
-  get ext() {
+  get ext(): string {
     return this.isUrl
       ? path.extname(new URL(this.path).pathname)
       : path.extname(this.path);