From e66cbcf262c17d3d412e7685a608ae15d98bfca2 Mon Sep 17 00:00:00 2001 From: cswimr Date: Tue, 31 Dec 2024 10:37:41 -0500 Subject: [PATCH] refactor: create a public dictionary for turret damage types --- Models/Enums.cs | 13 +++++++++++++ Models/Turret.cs | 10 +--------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/Models/Enums.cs b/Models/Enums.cs index 90a9034..62b2b76 100644 --- a/Models/Enums.cs +++ b/Models/Enums.cs @@ -1,3 +1,5 @@ +using System.Collections.Generic; + namespace ZenithInfo.Models { public enum ModuleSizes @@ -29,4 +31,15 @@ namespace ZenithInfo.Models Railgun, PulseLaser, } + + public Dictionary TurretDamageTypes { get; } = + new Dictionary + { + { TurretTypes.Artillery, DamageTypes.Hull }, + { TurretTypes.Autocannon, DamageTypes.Hull }, + { TurretTypes.BeamLaser, DamageTypes.Shield }, + { TurretTypes.Blaster, DamageTypes.Shield }, + { TurretTypes.Railgun, DamageTypes.Hull }, + { TurretTypes.PulseLaser, DamageTypes.Shield }, + }; } diff --git a/Models/Turret.cs b/Models/Turret.cs index 7d617d7..7fa703d 100644 --- a/Models/Turret.cs +++ b/Models/Turret.cs @@ -20,15 +20,7 @@ namespace ZenithInfo.Models public DamageTypes DamageType() { - new Dictionary - { - { TurretTypes.Artillery, DamageTypes.Hull }, - { TurretTypes.Autocannon, DamageTypes.Hull }, - { TurretTypes.BeamLaser, DamageTypes.Shield }, - { TurretTypes.Blaster, DamageTypes.Shield }, - { TurretTypes.Railgun, DamageTypes.Hull }, - { TurretTypes.PulseLaser, DamageTypes.Shield }, - }[this.Type]; + TurretDamageTypes[this.Type]; } public DamageStats Dps(int range: 0)