From 4b80a922127bb0392a7a9a1b49fe47af240e971e Mon Sep 17 00:00:00 2001 From: Javier Ferrer Date: Thu, 4 Mar 2021 11:55:50 +0100 Subject: [PATCH] More explicit and self-explanatory `message_if_xl` default parameter value - New value based on what an AWS team suggest: https://github.com/awslabs/fhir-works-on-aws-authz-rbac/pull/24 --- .github/workflows/labeler.yml | 5 ++++- README.md | 6 +++++- action.yml | 11 +++++++---- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index b9cf918..02cbb44 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -16,5 +16,8 @@ jobs: m_max_size: '200' l_max_size: '450' fail_if_xl: 'true' - message_if_xl: 'This PR is sooooo big!! 😳' + message_if_xl: > + 'This PR exceeds the recommended size of 1000 lines. + Please make sure you are NOT addressing multiple issues with one PR. + Note this PR might be rejected due to its size.’ github_api_url: 'api.github.com' # It would be ideal to test this out pointing to a GitHub Enterprise server, but there are no testing environments available diff --git a/README.md b/README.md index d479ced..c8617ae 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,11 @@ jobs: m_max_size: '500' l_max_size: '1000' fail_if_xl: 'false' - message_if_xl: 'This PR is so big! Please, split it 😊' + message_if_xl: > + 'This PR exceeds the recommended size of 1000 lines. + Please make sure you are NOT addressing multiple issues with one PR. + Note this PR might be rejected due to its size.’ + github_api_url: 'api.github.com' ``` > If you want, you can customize all `*_max_size` with the size that fits in your project. diff --git a/action.yml b/action.yml index 3601711..6505633 100644 --- a/action.yml +++ b/action.yml @@ -21,15 +21,18 @@ inputs: required: false default: '1000' fail_if_xl: - description: 'Fail if the PR is of xl size' + description: 'Report GitHub Workflow failure if the PR size is xl allowing to forbid PR merge' required: false default: 'false' message_if_xl: - description: 'Message to show if the PR is xl size' + description: 'Message to show if the PR size is xl' required: false - default: '' + default: > + 'This PR exceeds the recommended size of 1000 lines. + Please make sure you are NOT addressing multiple issues with one PR. + Note this PR might be rejected due to its size.’ github_api_url: - description: 'URI to the API of your Github Server, necessary for Github Enterprise customers' + description: 'URI to the API of your Github Server, only necessary for Github Enterprise customers' required: false default: 'api.github.com' runs: