actions/setup-uv
1
0
Fork 0
mirror of https://github.com/astral-sh/setup-uv.git synced 2025-04-07 07:58:48 -04:00
Code Issues Projects Releases Packages Wiki Activity

Only log checksum is valid when it really is (#97)

Browse source
This commit is contained in:
Kevin Stillhammer 2024-09-21 21:10:22 +02:00 • committed by GitHub
parent abac0ce7b0
commit 8c3a35e468
WARNING! Although there is a key with this ID in the database it does not verify this commit! This commit is SUSPICIOUS.
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
dist/setup/index.js generated vendored
View file

@ -87930,7 +87930,7 @@ const core = __importStar(__nccwpck_require__(2186));
const known_checksums_1 = __nccwpck_require__(4379); const known_checksums_1 = __nccwpck_require__(4379);
function validateChecksum(checkSum, downloadPath, arch, platform, version) { function validateChecksum(checkSum, downloadPath, arch, platform, version) {
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
let isValid = true; let isValid = undefined;
if (checkSum !== undefined && checkSum !== "") { if (checkSum !== undefined && checkSum !== "") {
isValid = yield validateFileCheckSum(downloadPath, checkSum); isValid = yield validateFileCheckSum(downloadPath, checkSum);
} }
@ -87946,10 +87946,12 @@ function validateChecksum(checkSum, downloadPath, arch, platform, version) {
core.debug(`No known checksum found for ${key}.`); core.debug(`No known checksum found for ${key}.`);
} }
} }
if (!isValid) { if (isValid === false) {
throw new Error(`Checksum for ${downloadPath} did not match ${checkSum}.`); throw new Error(`Checksum for ${downloadPath} did not match ${checkSum}.`);
} }
if (isValid === true) {
core.debug(`Checksum for ${downloadPath} is valid.`); core.debug(`Checksum for ${downloadPath} is valid.`);
}
}); });
} }
function validateFileCheckSum(filePath, expected) { function validateFileCheckSum(filePath, expected) {

6
src/download/checksum/checksum.ts
View file

@ -12,7 +12,7 @@ export async function validateChecksum(
platform: Platform, platform: Platform,
version: string, version: string,
): Promise<void> { ): Promise<void> {
let isValid = true; let isValid: boolean | undefined = undefined;
if (checkSum !== undefined && checkSum !== "") { if (checkSum !== undefined && checkSum !== "") {
isValid = await validateFileCheckSum(downloadPath, checkSum); isValid = await validateFileCheckSum(downloadPath, checkSum);
} else { } else {
@ -27,11 +27,13 @@ export async function validateChecksum(
} }
} }
if (!isValid) { if (isValid === false) {
throw new Error(`Checksum for ${downloadPath} did not match ${checkSum}.`); throw new Error(`Checksum for ${downloadPath} did not match ${checkSum}.`);
} }
if (isValid === true) {
core.debug(`Checksum for ${downloadPath} is valid.`); core.debug(`Checksum for ${downloadPath} is valid.`);
} }
}
async function validateFileCheckSum( async function validateFileCheckSum(
filePath: string, filePath: string,