From 2505dd0980dfe4199dcd08372e50655d96b80011 Mon Sep 17 00:00:00 2001
From: cswimr <seaswimmerthefsh@gmail.com>
Date: Fri, 28 Mar 2025 10:22:08 -0500
Subject: [PATCH] fix(aurora): more ruff fixes

---
 aurora/aurora.py             |  4 ++--
 aurora/utilities/database.py |  6 +++---
 aurora/utilities/factory.py  |  8 ++++----
 aurora/utilities/utils.py    | 20 +++++---------------
 4 files changed, 14 insertions(+), 24 deletions(-)

diff --git a/aurora/aurora.py b/aurora/aurora.py
index d2dca4a..955b5cc 100644
--- a/aurora/aurora.py
+++ b/aurora/aurora.py
@@ -40,7 +40,7 @@ class Aurora(commands.Cog):
     This cog stores all of its data in an SQLite database."""
 
     __author__ = ["cswimr"]
-    __version__ = "2.1.4"
+    __version__ = "2.1.5"
     __documentation__ = "https://seacogs.coastalcommits.com/aurora/"
 
     async def red_delete_data_for_user(self, *, requester, user_id: int):
@@ -872,7 +872,7 @@ class Aurora(commands.Cog):
                 silent = not await config.guild(interaction.guild).dm_users()
             if silent is False:
                 try:
-                    embed = embed = await message_factory(
+                    embed = await message_factory(
                         await self.bot.get_embed_color(interaction.channel),
                         guild=interaction.guild,
                         moderator=interaction.user,
diff --git a/aurora/utilities/database.py b/aurora/utilities/database.py
index fd1f721..aa876e8 100644
--- a/aurora/utilities/database.py
+++ b/aurora/utilities/database.py
@@ -14,12 +14,12 @@ from .utils import convert_timedelta_to_str, generate_dict, get_next_case_number
 def connect() -> sqlite3.Connection:
     """Connects to the SQLite database, and returns a connection object."""
     try:
-        connection = sqlite3.connect(database=data_manager.cog_data_path(raw_name="Aurora") / "aurora.db")
-        return connection
+        return sqlite3.connect(database=data_manager.cog_data_path(raw_name="Aurora") / "aurora.db")
 
     except sqlite3.OperationalError as e:
         logger.error("Unable to access the SQLite database!\nError:\n%s", e.msg)
-        raise ConnectionRefusedError(f"Unable to access the SQLite Database!\n{e.msg}") from e
+        msg = f"Unable to access the SQLite Database!\n{e.msg}"
+        raise ConnectionRefusedError(msg) from e
 
 
 async def create_guild_table(guild: Guild):
diff --git a/aurora/utilities/factory.py b/aurora/utilities/factory.py
index 2d060b0..4c54a1d 100644
--- a/aurora/utilities/factory.py
+++ b/aurora/utilities/factory.py
@@ -451,7 +451,7 @@ async def addrole_embed(ctx: commands.Context) -> Embed:
                         "id": evalulated_role.id,
                         "mention": evalulated_role.mention,
                         "position": evalulated_role.position,
-                    }
+                    },
                 )
             else:
                 roles.append(
@@ -459,7 +459,7 @@ async def addrole_embed(ctx: commands.Context) -> Embed:
                         "id": role,
                         "mention": error(f"`{role}` (Not Found)"),
                         "position": 0,
-                    }
+                    },
                 )
 
     if roles:
@@ -506,7 +506,7 @@ async def immune_embed(ctx: commands.Context) -> Embed:
                         "id": evalulated_role.id,
                         "mention": evalulated_role.mention,
                         "position": evalulated_role.position,
-                    }
+                    },
                 )
             else:
                 roles.append(
@@ -514,7 +514,7 @@ async def immune_embed(ctx: commands.Context) -> Embed:
                         "id": role,
                         "mention": error(f"`{role}` (Not Found)"),
                         "position": 0,
-                    }
+                    },
                 )
 
     if roles:
diff --git a/aurora/utilities/utils.py b/aurora/utilities/utils.py
index d99bfcd..049eb0d 100644
--- a/aurora/utilities/utils.py
+++ b/aurora/utilities/utils.py
@@ -104,7 +104,7 @@ async def get_next_case_number(guild_id: str, cursor=None) -> int:
 
 
 def generate_dict(result) -> dict:
-    case = {
+    return {
         "moderation_id": result[0],
         "timestamp": result[1],
         "moderation_type": result[2],
@@ -122,7 +122,6 @@ def generate_dict(result) -> dict:
         "changes": json.loads(result[14]),
         "metadata": json.loads(result[15]),
     }
-    return case
 
 
 async def fetch_user_dict(client: commands.Bot, user_id: str) -> dict:
@@ -175,11 +174,9 @@ async def fetch_role_dict(guild: Guild, role_id: int) -> dict:
     """This function returns a dictionary containing either role information or a standard deleted role template."""
     role = guild.get_role(int(role_id))
     if not role:
-        role_dict = {"id": role_id, "name": "Deleted Role"}
+        pass
 
-    role_dict = {"id": role.id, "name": role.name}
-
-    return role_dict
+    return {"id": role.id, "name": role.name}
 
 
 async def log(interaction: Interaction, moderation_id: int, resolved: bool = False) -> None:
@@ -245,16 +242,9 @@ def create_pagesize_options() -> list[SelectOption]:
             label="Default",
             value="default",
             description="Reset the pagesize to the default value.",
-        )
+        ),
     )
-    for i in range(1, 21):
-        options.append(
-            SelectOption(
-                label=str(i),
-                value=str(i),
-                description=f"Set the pagesize to {i}.",
-            )
-        )
+    options.extend(SelectOption(label=str(i), value=str(i), description=f"Set the pagesize to {i}") for i in range(1, 21))
     return options