From f233a7dec5061f6ff01110c1c6e532a459bed330 Mon Sep 17 00:00:00 2001 From: cswimr Date: Sun, 26 Jan 2025 00:46:00 +0000 Subject: [PATCH 1/5] fix(hotreload): mark `cog_load` and `cog_unload` as async --- hotreload/hotreload.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hotreload/hotreload.py b/hotreload/hotreload.py index 143d2f6..d039a8a 100644 --- a/hotreload/hotreload.py +++ b/hotreload/hotreload.py @@ -16,7 +16,7 @@ class HotReload(commands.Cog): __author__ = ["[cswimr](https://www.coastalcommits.com/cswimr)"] __git__ = "https://www.coastalcommits.com/cswimr/SeaCogs" - __version__ = "1.1.1" + __version__ = "1.1.2" __documentation__ = "https://seacogs.coastalcommits.com/hotreload/" def __init__(self, bot: Red) -> None: @@ -28,11 +28,11 @@ class HotReload(commands.Cog): for watchdog_logger in watchdog_loggers: watchdog_logger.setLevel("INFO") # SHUT UP!!!! - def cog_load(self) -> None: + async def cog_load(self) -> None: """Start the observer when the cog is loaded.""" self.bot.loop.create_task(self.start_observer()) - def cog_unload(self) -> None: + async def cog_unload(self) -> None: """Stop the observer when the cog is unloaded.""" if self.observer: self.observer.stop() From 8511b7b964bc0f37197044091583a5655b6a4cde Mon Sep 17 00:00:00 2001 From: cswimr Date: Sun, 26 Jan 2025 00:46:21 +0000 Subject: [PATCH 2/5] fix(bible): mark `cog_unload` as async --- bible/bible.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bible/bible.py b/bible/bible.py index 1b44169..9cf520b 100644 --- a/bible/bible.py +++ b/bible/bible.py @@ -39,7 +39,7 @@ class Bible(commands.Cog): self.config.register_global(bible="de4e12af7f28f599-02") self.config.register_user(bible=None) - def cog_unload(self): + async def cog_unload(self): create_task(self.session.close()) def format_help_for_context(self, ctx: commands.Context) -> str: From 451ecfe5d991f6e9fe08bcbefaf6398c5321c4a8 Mon Sep 17 00:00:00 2001 From: cswimr Date: Sun, 26 Jan 2025 00:48:25 +0000 Subject: [PATCH 3/5] chore(tooling): disable `too-many-positional-arguments` --- .forgejo/workflows/config/.pylintrc | 1 + 1 file changed, 1 insertion(+) diff --git a/.forgejo/workflows/config/.pylintrc b/.forgejo/workflows/config/.pylintrc index 94010af..4874462 100644 --- a/.forgejo/workflows/config/.pylintrc +++ b/.forgejo/workflows/config/.pylintrc @@ -12,6 +12,7 @@ too-many-locals, too-many-public-methods, too-many-statements, + too-many-positional-arguments, arguments-differ, too-many-return-statements, import-outside-toplevel, From 1677412b56414948a90731810d1ce45261c7555f Mon Sep 17 00:00:00 2001 From: cswimr Date: Sun, 26 Jan 2025 00:56:50 +0000 Subject: [PATCH 4/5] chore(hotreload): add disclaimer in install message that this cog doesn't add any commands --- hotreload/info.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hotreload/info.json b/hotreload/info.json index 7d47a1e..87dc851 100644 --- a/hotreload/info.json +++ b/hotreload/info.json @@ -1,6 +1,6 @@ { "author" : ["cswimr"], - "install_msg" : "Thank you for installing HotReload!", + "install_msg" : "Thank you for installing HotReload! This cog does not provide any commands, please see the [documentation](https://seacogs.coastalcommits.com/hotreload) for more information.", "name" : "HotReload", "short" : "Automatically reload cogs in local cog paths on file change.", "description" : "Automatically reload cogs in local cog paths on file change.", From e5210420cb5348e7173288545d5b7e843c3af556 Mon Sep 17 00:00:00 2001 From: cswimr Date: Sun, 26 Jan 2025 01:08:06 +0000 Subject: [PATCH 5/5] chore(vscode): force load `hotreload` in launch & debug configuration --- .vscode/launch.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 84a95c2..9a7e46e 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -5,11 +5,11 @@ "version": "0.2.0", "configurations": [ { - "name": "Red-DiscordBot", + "name": "Python: Red-DiscordBot", "type": "debugpy", "request": "launch", "module": "redbot", - "args": ["local", "--dev", "-vvv"] + "args": ["local", "--dev", "-vvv", "--load-cogs=hotreload"] } ] }