From bb707fb28779158d29a7a619ab100e6fccd9bd73 Mon Sep 17 00:00:00 2001 From: Paul Date: Sun, 26 Dec 2021 15:03:44 +0000 Subject: [PATCH] fix(settings): persist false-y values --- src/mobx/stores/Settings.ts | 3 ++- src/pages/home/Home.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mobx/stores/Settings.ts b/src/mobx/stores/Settings.ts index 237566b1..1a90dbe4 100644 --- a/src/mobx/stores/Settings.ts +++ b/src/mobx/stores/Settings.ts @@ -75,7 +75,8 @@ export default class Settings @action hydrate(data: ISettings) { Object.keys(data).forEach( (key) => - (data as any)[key] && this.data.set(key, (data as any)[key]), + typeof (data as any)[key] !== "undefined" && + this.data.set(key, (data as any)[key]), ); } diff --git a/src/pages/home/Home.tsx b/src/pages/home/Home.tsx index 1429e52f..4d51eb05 100644 --- a/src/pages/home/Home.tsx +++ b/src/pages/home/Home.tsx @@ -51,7 +51,7 @@ export default observer(() => { !state.settings.get("appearance:seasonal"), ); - const seasonalTheme = state.settings.get("appearance:seasonal") ?? true; + const seasonalTheme = state.settings.get("appearance:seasonal", true); const isDecember = !isTouchscreenDevice && new Date().getMonth() === 11; const snowflakes = useMemo(() => { const flakes = [];