bible: Migrate to new API.Bible API #122

Merged

cswimr merged 38 commits from bible/new-bible-api into main 2025-10-14 03:40:24 -04:00

Conversation 0 Commits 38 Files changed 32 +1065 -387

cswimr commented 2025-10-11 14:01:12 -04:00

Owner

Copy link

Currently, the Bible cog is broken because it uses the legacy, deprecated API.Bible API. This PR virtually rewrites the entire cog to use the new API, as well as a host of other improvements.

• By submitting this pull request, I permit cswimr to license my work under
  the Mozilla Public License Version 2.0.

Currently, the Bible cog is broken because it uses the legacy, deprecated API.Bible API. This PR virtually rewrites the entire cog to use the new API, as well as a host of other improvements. <!-- Create a new issue, if it doesn't exist yet --> - [x] By submitting this pull request, I permit [cswimr](https://c.csw.im/cswimr) to license my work under the [Mozilla Public License Version 2.0](https://c.csw.im/cswimr/SeaCogs/src/branch/main/LICENSE).

cswimr added the

bug

enhancement

cog

Bible

labels 2025-10-11 14:01:12 -04:00

cswimr self-assigned this 2025-10-11 14:01:12 -04:00

cswimr added 16 commits 2025-10-11 14:01:12 -04:00

bible: total overhaul, migrate to new api.bible api 44d13fb24d

bible: use exception classes from tidegear 3453fdfc83

bible: make bible a hybrid group 97942b2546

bible: correct typehint 29f26e4e47

bible: improve /bible passage docstring 4a2b2a7e91

bible: improve footer text 8d625735cc

bible: add disclaimer that the cog uses API.Bible in responses ff4a10a702

bible: default to the catholic version of the KJV ... e591547da1

I myself (cswimr) am Independent Baptist. However, as far as I am aware, the only difference between the Catholic and Protestant versions of this translation is the presence of the Apocryha. If this turns out to not be the case, this cog will begin defaulting to the Protestant version of this translation, without previous warning.

bible: correct a comment 98bb932d2d

bible: switch back to the protestant kjv version 47582e28a8

bible: re-arrange footer text so copyright disclaimer makes more sense 9691daaef0

bible: update docs ca60cb2741

bible: rename an argument 51796a3f6c

bible: general command cleanup 6e6b81d4ce

bible: raise NotFoundError if the API can't find a bible with a given ID 2f9d4f7bec

bible: update tidegear 37d02e872a

cswimr changed title from Bible: Migrate to new API.Bible API to WIP: Bible: Migrate to new API.Bible API 2025-10-11 14:01:22 -04:00

cswimr pinned this 2025-10-11 14:01:33 -04:00

cswimr added 1 commit 2025-10-11 14:03:22 -04:00

bible: remove useless cog_unload override 0ba701e414

cswimr added 1 commit 2025-10-11 14:03:48 -04:00

bible: correct typehint 06622a1474

cswimr added 1 commit 2025-10-11 14:05:54 -04:00

bible: update version constraint 8fdd2abfd9

cswimr added 2 commits 2025-10-12 00:49:02 -04:00

bible: update tidegear c18b037eb5

bible: improve cache setup for bibles 25ec39de24

cswimr added 2 commits 2025-10-12 04:05:19 -04:00

bible: correct typehint 5f8b7f4594

bible: refactor exception handling f864234330

cswimr added 4 commits 2025-10-12 05:02:48 -04:00

bible: add name property and __str__ method to Reference d689b6e50f

bible: cache passages using aiocache 2768736d75

bible: correct typehints 3bcdc9ebda

bible: add overloads for fetch_bible_for_context; minor other tweaks 3ccfad983e

cswimr added 2 commits 2025-10-12 05:19:49 -04:00

bible: correct cache key function 66e9cd2f4e

bible: check cache before doing instance check, so the check doesn't run twice for no reason b3fc15aa5a

cswimr added 1 commit 2025-10-12 18:05:16 -04:00

bible: add hyperlinks to error messages db412abe85

cswimr added 1 commit 2025-10-12 18:07:31 -04:00

bible: update tidegear fdb2530446

cswimr added 1 commit 2025-10-13 16:40:35 -04:00

bible: update tidegear 1983779aa7

cswimr added 1 commit 2025-10-13 17:11:59 -04:00

repo: add typestubs for the aiocache library; pin aiocache version 5ddf34b21d

cswimr added 1 commit 2025-10-13 17:14:54 -04:00

repo: clean up typestubs 43537f9027

cswimr added 1 commit 2025-10-13 17:15:29 -04:00

repo: remove useless ruff suppression b2cb3b8cb8

cswimr added 1 commit 2025-10-13 17:38:31 -04:00

bible: bunch of stuff 267edbd317

cswimr added 2 commits 2025-10-14 03:24:43 -04:00

bible: update tidegear 70b2b4a5f8

bible: change some typehints e7795d5b68

cswimr changed title from WIP: Bible: Migrate to new API.Bible API to Bible: Migrate to new API.Bible API 2025-10-14 03:28:18 -04:00

cswimr changed title from Bible: Migrate to new API.Bible API to bible: Migrate to new API.Bible API 2025-10-14 03:28:23 -04:00

cswimr merged commit bc13934121 into main 2025-10-14 03:40:24 -04:00

cswimr deleted branch bible/new-bible-api 2025-10-14 03:40:24 -04:00

cswimr referenced this pull request from a commit 2025-10-14 03:40:25 -04:00

bible: Migrate to new API.Bible API (#122)

cswimr unpinned this 2025-10-14 04:19:21 -04:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

cog

New cog

  

cog

Aurora

Issue relates to the Aurora cog

  

cog

Backup

Issue relates to the Backup cog

  

cog

Bible

Issue relates to the Bible cog

  

cog

EmojiInfo

Issue relates to the EmojiInfo cog

  

cog

HotReload

Issue relates to the HotReload cog

  

cog

Nerdify

Issue relates to the Nerdify cog

  

cog

Pterodactyl

Issue relates to the Pterodactyl cog

  

cog

SeaUtils

Issue relates to the SeaUtils cog

  

cog

SentinelCore

Issue relates to the SentinelCore cog

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

cog

cog

Aurora

cog

Backup

cog

Bible

cog

EmojiInfo

cog

HotReload

cog

Nerdify

cog

Pterodactyl

cog

SeaUtils

cog

SentinelCore

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

cswimr

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cswimr/SeaCogs!122

No description provided.